Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route53_facts: add check mode support #56900

Merged
merged 4 commits into from
May 27, 2019
Merged

route53_facts: add check mode support #56900

merged 4 commits into from
May 27, 2019

Conversation

zyv
Copy link
Contributor

@zyv zyv commented May 24, 2019

SUMMARY

This PR adds check mode support for route53_facts.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

route53_facts

@ansibot
Copy link
Contributor

ansibot commented May 24, 2019

cc @Etherdaemon
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 24, 2019

@zyv, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels May 24, 2019
@zyv
Copy link
Contributor Author

zyv commented May 24, 2019

/cc @marns93 @felixfontein @Akasurde

@Akasurde Akasurde requested review from jillr and Akasurde May 24, 2019 11:33
Akasurde
Akasurde approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 24, 2019
felixfontein
felixfontein approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Needs a changelog fragment, though.

@zyv
Copy link
Contributor Author

zyv commented May 24, 2019

Hi @felixfontein, sorry, we didn't know about fragments, must be something new! Maybe worth teaching the bot or CI to nag submitters about it. Anyways, just added one, hopefully correctly; thank you for taking your time to check this PR out!

felixfontein
felixfontein reviewed May 24, 2019
View reviewed changes
changelogs/fragments/56900-route53-facts-check-mode.yaml Outdated
@@ -0,0 +1,2 @@
minor_changes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should be a bugfix, not a new feature. The module should have advertised that it supports check mode since the beginning.

@felixfontein
Copy link
Contributor

@zyv changelog fragments were introduced a year ago (just looked it up, the first announcement came on June 5th 2018 :) ). I'm not sure since when they are mandatory; the problem with CI/bot complaining about them is that they are not necessary for everything (a lot of doc changes don't require them, for example), and I'm not aware of current discussions/ideas of whether / how to enforce them.

@zyv @felixfontein
Update changelogs/fragments/56900-route53-facts-check-mode.yaml
4b920a4 
Co-Authored-By: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resmo
resmo approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit fcfc122 into ansible:devel May 27, 2019
@felixfontein
Copy link
Contributor

@zyv do you want to create a backport to stable-2.8? Or anyone else wants to do it?

@zyv zyv mentioned this pull request May 28, 2019
Merged
abadger pushed a commit that referenced this pull request May 28, 2019
@zyv @felixfontein @abadger
route53_facts: add check mode support (#56900)
776aa01 
* route53_facts: add check mode support

* route53_facts: add changelog fragment mentioning check mode support

* route53_facts: alter changelog fragment type from `minor_changes` to `bugfixes`

* Update changelogs/fragments/56900-route53-facts-check-mode.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@Akasurde Akasurde Akasurde approved these changes

@felixfontein felixfontein felixfontein approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zyv @ansibot @felixfontein @resmo @Akasurde @catcombo